Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review updates #652

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Review updates #652

merged 8 commits into from
Sep 13, 2023

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Sep 11, 2023

Changes

  • Open data usage links in a new tab
  • Open Hub in a new tab
  • Allow specifying banner images for the development and about pages

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 68f9a36
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/650206937c8be4000776f5d8
😎 Deploy Preview https://deploy-preview-652--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slesaad slesaad marked this pull request as ready for review September 12, 2023 00:05
slesaad and others added 2 commits September 12, 2023 13:12
Co-authored-by: Daniel da Silva <[email protected]>
@slesaad
Copy link
Member Author

slesaad commented Sep 13, 2023

Actually, might not even need those updates; I just read this in the mdn web docs
image

@danielfdsilva danielfdsilva merged commit c88145f into main Sep 13, 2023
@danielfdsilva danielfdsilva deleted the ui-review-updates branch September 13, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants